Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags

From: David Miller
Date: Fri Nov 03 2017 - 02:55:09 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 2 Nov 2017 20:04:12 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
>
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.