Re: [PATCH 1/2] mm: extract common code for calculating total memory size

From: Yang Shi
Date: Fri Oct 27 2017 - 12:52:19 EST




On 10/27/17 3:00 AM, Christopher Lameter wrote:
On Thu, 26 Oct 2017, Yang Shi wrote:

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 935c4d4..e21b81e 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2050,6 +2050,31 @@ extern int __meminit __early_pfn_to_nid(unsigned long pfn,
static inline void zero_resv_unavail(void) {}
#endif

+static inline void calc_mem_size(unsigned long *total, unsigned long *reserved,
+ unsigned long *highmem)
+{

Huge incline function. This needs to go into mm/page_alloc.c or
mm/slab_common.c

It is used by lib/show_mem.c too. But since it is definitely on a hot patch, I think I can change it to non inline.

Thanks,
Yang