Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

From: Marian Mihailescu
Date: Wed Oct 25 2017 - 18:28:15 EST


Hi Shuah,

For MFC patch, you can delete the "dev" variable since it's not being
used anymore and results in a compile warning.

- struct s5p_mfc_dev *dev = ctx->dev;

Cheers,
Marian

On Thu, Oct 26, 2017 at 7:54 AM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> On 10/06/2017 03:30 PM, Shuah Khan wrote:
>> This patch series fixes inefficiencies and lock contention in the request
>> firmware paths.
>>
>> Shuah Khan (2):
>> media: s5p-mfc: check for firmware allocation before requesting
>> firmware
>> media: s5p-mfc: fix lock confection - request_firmware() once and keep
>> state
>>
>> drivers/media/platform/s5p-mfc/s5p_mfc.c | 4 ++++
>> drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 3 +++
>> drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 15 ++++++++++-----
>> 3 files changed, 17 insertions(+), 5 deletions(-)
>>
>
> Any feedback on this series?
>
> thanks,
> -- Shuah