Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus_scanf()

From: Levin, Alexander (Sasha Levin)
Date: Mon Oct 23 2017 - 21:39:56 EST


On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote:
>On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
>> From: Jan Beulich <JBeulich@xxxxxxxx>
>>
>> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>>
>> A negative return value indicates an error; in fact the function at
>> present won't ever return zero.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
>
>This patch will cause a warning to be printed. Please pull commit
>4e93b64 ("xen: don't print error message in case of missing Xenstore
>entry") as well.

Added, thanks Boris.

--

Thanks,
Sasha