Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

From: John Stultz
Date: Mon Oct 23 2017 - 17:36:12 EST


On Mon, Oct 23, 2017 at 1:41 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan
> <Minas.Harutyunyan@xxxxxxxxxxxx> wrote:
>> Could you please verify on your setup follow patches:
>> 1. Vardan's patch.
>> 2. Patch for TOUTCAL&USBTRDTIM programming (new version see below).
>> 4. Your patch 2/3 to avoid "Mode Mismatch" interrupts.
>> 5. Your patch 3/3 to set udc state to "not attached".
>> 6. Your patch 1/3, but remove dwc2_hsotg_core_init_disconnected()
>> function call from Host starting brnch, keep *only*
>> dwc2_hsotg_disconnect() to change UDC state to "not attached".
>
> So yes, this set does seem to work ok for me. Though neither Vardan's
> patch or the TOUTCAL/USBTRDTIM patch seem to have much effect either
> way (I need to do more testing just to be sure, but for the use cases
> I've had trouble with they don't seem to do much).
>
> I'm happy to rework my earlier patch #1/3 to remove
> dwc2_hsotg_core_init_disconnected() and resend.

Just resent the set of my changes with the above tweak.

The stack including Vardan's and your fixes that I also tested with
(but to little effect) can be found here:
https://git.linaro.org/people/john.stultz/android-dev.git/log/?id=4302a823816e944a6f548b05049c4e4c006bbadd

thanks
-john