Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

From: Amit Kucheria
Date: Mon Oct 23 2017 - 01:02:03 EST


On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote:
> On 10/18/17 3:57 PM, Amit Kucheria wrote:
>>
>> Enable panic and disk activity triggers to tie to LED activity
>
>
> Could you provide some explanation as to why we want this enabled for ARM64?
> I don't have a problem with the change itself, but I think patch
> descriptions for defconfig changes should include justifications.

Indeed.

The blurb should be modified as follows:

"Most development boards and devices have one or more LEDs. It is
useful during debugging if they can be wired to show different
behaviours such as disk or cpu activity or a load-average dependent
heartbeat. Enable panic and disk activity triggers so they can be tied
to LED activity during debugging as well."

If this blurb works, I'll send out another version.