Re: [PATCH] USB: add SPDX identifiers to all files in drivers/usb/

From: Rob Herring
Date: Fri Oct 20 2017 - 11:26:49 EST


On Thu, Oct 19, 2017 at 3:38 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> It's good to have SPDX identifiers in all files to make it easier to
> audit the kernel tree for correct licenses. This patch adds these
> identifiers to all files in drivers/usb/ based on a script and data from
> Thomas Gleixner, Philippe Ombredanne, and Kate Stewart.
>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> Cc: Philippe Ombredanne <pombredanne@xxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Unless someone really complains, I'm going to add this to my tree for
> 4.15-rc1.

Glad to see this. I've been suggesting folks use SPDX tags on dts
files as those are often dual licensed, so we have lots of license
boilerplate. But I've had some push back[1] but it's not something I
care to spend cycles on. It would be good to have some statement on
the use of tags. Anything new should use them (I can dust off my
checkpatch.pl check for this)? This is a good task for newbies? It's
each maintainer's decision? It's the copyright holder's (and their
lawyer's) decision?

Rob

[1] https://lkml.org/lkml/2017/2/28/750