Re: [PATCH -mm -V2] mm, pagemap: Fix soft dirty marking for PMD migration entry

From: Kirill A. Shutemov
Date: Fri Oct 20 2017 - 05:31:00 EST


On Thu, Oct 19, 2017 at 03:10:46PM +0000, Huang, Ying wrote:
> From: Huang Ying <ying.huang@xxxxxxxxx>
>
> Now, when the page table is walked in the implementation of
> /proc/<pid>/pagemap, pmd_soft_dirty() is used for both the PMD huge
> page map and the PMD migration entries. That is wrong,
> pmd_swp_soft_dirty() should be used for the PMD migration entries
> instead because the different page table entry flag is used.
> Otherwise, the soft dirty information in /proc/<pid>/pagemap may be
> wrong.
>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>

As I said before, you can use my ack for this.

--
Kirill A. Shutemov