Re: [PATCH v3 09/49] block: comment on bio_iov_iter_get_pages()

From: Ming Lei
Date: Thu Oct 19 2017 - 18:56:27 EST


On Thu, Aug 10, 2017 at 04:28:05AM -0700, Christoph Hellwig wrote:
> > + * The hacking way of using bvec table as page pointer array is safe
> > + * even after multipage bvec is introduced because that space can be
> > + * thought as unused by bio_add_page().
>
> I'm not sure what value this comment adds.
>
> Note that once we have multi-page biovecs this could should change
> to take advantage of multipage biovecs, so adding a comment before
> that doesn't seem too helpful.

As mentioned in comment on patch 8, bio_alloc_pages() should be move
to bcache.

--
Ming