Re: [PATCH][next] mqprio: fix potential null pointer dereference on opt

From: David Miller
Date: Thu Oct 19 2017 - 08:16:02 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 17 Oct 2017 16:01:30 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The pointer opt has a null check however before for this check opt is
> dereferenced when len is initialized, hence we potentially have a null
> pointer deference on opt. Avoid this by checking for a null opt before
> dereferencing it.
>
> Detected by CoverityScan, CID#1458234 ("Dereference before null check")
>
> Fixes: 4e8b86c06269 ("mqprio: Introduce new hardware offload mode and shaper in mqprio")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.