Re: [PATCH v6 2/5] clocksource: stm32: convert driver to timer_of

From: Thomas Gleixner
Date: Wed Oct 18 2017 - 14:31:52 EST


On Wed, 18 Oct 2017, Benjamin Gaignard wrote:

> Convert driver to use timer_of helpers. This allow to remove
> custom proprietary structure.
>
> Increase min delta value because if it is too small it could
> generate too much interrupts and the system will not be able
> to catch them all.

This does two completely independent changes at once. What the heck has
increasing min delta to do with converting it to timer_of() helpers?

Nothing at all. So please split this into two distinct patches. Each doing
ONE thing.

See Documentation/process/submitting-patches.rst:

3) Separate your changes
------------------------

Separate each **logical change** into a separate patch.

Reading, understanding and complying with that document is not optional.

Thanks,

tglx