Re: [PATCH] Staging: rtlwifi: phydm: Use setup_timer

From: Greg KH
Date: Wed Oct 18 2017 - 09:53:41 EST


On Sat, Oct 07, 2017 at 10:56:25PM +0530, Srishti Sharma wrote:
> Use setup_timer to combine initialization of a timer with the
> initialization of the timer's function and data fields. Done
> using the following semantic patch by coccinelle.
>
> @r@
> struct timer_list *l;
> expression f, d;
> @@
>
> -init_timer(l);
> +setup_timer(l,f,d);
> ...
>
> (
> - l->function = f;
> ...
> - l->data = d;
> |
> - l->data = d;
> ...
> - l->function = f;
> )
>
> Signed-off-by: Srishti Sharma <srishtishar@xxxxxxxxx>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> ---
> drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Due to other changes in this same function, this patch no longer
applies, sorry.

greg k-h