Re: [PATCH] phy: Return NULL if the phy is optional

From: Kishon Vijay Abraham I
Date: Wed Oct 18 2017 - 07:13:04 EST




On Monday 04 September 2017 06:23 PM, Maxime Ripard wrote:
> If we're trying to get a handle to an optional phy, then the phy framework
> being disabled shouldn't return an hard error.
>
> Instead, return NULL just like phy_optional_get does when there's no phy
> provided in the DT.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

merged, thanks!

-Kishon
> ---
> include/linux/phy/phy.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 78bb0d7f6b11..76487b8d74ea 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -289,7 +289,7 @@ static inline struct phy *devm_phy_get(struct device *dev, const char *string)
> static inline struct phy *devm_phy_optional_get(struct device *dev,
> const char *string)
> {
> - return ERR_PTR(-ENOSYS);
> + return NULL;
> }
>
> static inline struct phy *devm_of_phy_get(struct device *dev,
>