Re: [PATCH v3 00/12] of: overlay: clean up device tree overlay code

From: Rob Herring
Date: Tue Oct 17 2017 - 21:50:19 EST


On Tue, Oct 17, 2017 at 6:36 PM, <frowand.list@xxxxxxxxx> wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> I have found the device tree overlay code to be difficult to read and
> maintain. This patch series attempts to improve that situation.
>
> The cleanup includes some changes visible to users of overlays. The
> only in kernel user of overlays is fixed up for those changes. The
> in kernel user is:
>
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
>
> Following the cleanup patches are a set of patches to fix various
> issues.
>
> The first five patches are intended to not make any functional
> changes, and are segrated to ease review.
>
> Version 3 applies on top of ac0f3e30d87e "of: overlay: fix memory
> leak related to duplicated property"
>
>
>
> Changes from version 2:
> - rebase on Rob's dt/next branch
> - 3/12: do missing renames in of_fill_overlay_info() so that 3/12
> and 4/12 build. This function is removed in 5/12.
>
> Changes from version 1:
>
> - squash "[PATCH] of: overlay: move resolve phandles into
> of_overlay_apply()" into "[PATCH 09/12] of: overlay: avoid race
> condition between applying multiple overlays"
>
>
> Frank Rowand (12):
> of: overlay.c: Remove comments that state the obvious, to reduce
> clutter
> of: overlay.c: Convert comparisons to zero or NULL to logical
> expressions
> of: overlay: rename identifiers to more reflect what they do
> of: overlay: rename identifiers in dup_and_fixup_symbol_prop()
> of: overlay: minor restructuring
> of: overlay: detect cases where device tree may become corrupt
> of: overlay: expand check of whether overlay changeset can be removed
> of: overlay: loosen overly strict phandle clash check
> of: overlay: avoid race condition between applying multiple overlays
> of: overlay: simplify applying symbols from an overlay
> of: overlay: remove a dependency on device node full_name
> of: overlay: remove unneeded check for NULL kbasename()
>
> Documentation/devicetree/overlay-notes.txt | 12 +-
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 14 +-
> drivers/of/base.c | 2 +-
> drivers/of/dynamic.c | 137 +++-
> drivers/of/of_private.h | 22 +-
> drivers/of/overlay.c | 1042 ++++++++++++++++----------
> drivers/of/resolver.c | 7 +
> drivers/of/unittest.c | 81 +-
> include/linux/of.h | 17 +-
> 9 files changed, 874 insertions(+), 460 deletions(-)

Series applied.

Rob