Re: [GIT PULL] KEYS: Fixes

From: Eric Biggers
Date: Tue Oct 17 2017 - 19:23:28 EST


+Cc tyhicks@xxxxxxxxxxxxx

Hi David,

On Tue, Oct 17, 2017 at 11:57:33PM +0100, David Howells wrote:
>
> (2) Fix some ecryptfs bits.

Sorry for the late notice, but just looking at it again I think the patch
"ecryptfs: fix out-of-bounds read of key payload" is broken because the
->private_key is of variable-length. See
ecryptfs_add_key_module_key_to_keyring() in ecryptfs-utils.

So can you please drop the following two patches:

ecryptfs: fix out-of-bounds read of key payload
ecryptfs: move key payload accessor functions into keystore.c

I'll fix them and try to get Tyler Hicks to take them through the ecryptfs tree
later instead.

Eric