Re: scripts/checkpatch: Concatenated strings should use spaces between elements

From: Joe Perches
Date: Tue Oct 17 2017 - 18:43:21 EST


On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote:
> This patch creates a warning (CHECK)
> "Concatenated strings should use spaces between elements"
>
> There are no concatenated strings here.

Yes, there are.

> (checkpatch is also used in the U-Boot project where wide strings
> occur in the EFI implementation.)
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
> test.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 test.c
>
> diff --git a/test.c b/test.c
> new file mode 100644
> index 0000000000..dfd33cd765
> --- /dev/null
> +++ b/test.c
> @@ -0,0 +1,6 @@
> +#include <foo.h>
> +
> +void foo(void)
> +{
> + test(L"\"");

In this case, L must be a constant string and you
are concatenating L and "\""