Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

From: Dan Carpenter
Date: Tue Oct 17 2017 - 05:46:10 EST


On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
>
>
> On Tue, 17 Oct 2017, Dan Carpenter wrote:
>
> > On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
> > >
> > > A minor complaint: all commits are missing "Fixes:" tag.
> > >
> >
> > Fixes is only for bug fixes. These don't fix any bugs.
>
> 0-day seems to put Fixes for everything. Should they be removed when the
> old code is undesirable but doesn't actually cause a crash, eg out of date
> API.

Yeah, I feel like Fixes tags don't belong for API updates and cleanups.

regards,
dan carpenter