Re: [RFC v4 2/8] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates

[Kuppuswamy, Sathyanarayanan]

Hi,


On 10/7/2017 9:13 AM, Andy Shevchenko wrote:
> On Sat, Oct 7, 2017 at 5:33 AM,
> <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> >
> > Currently, update_no_reboot_bit() function implemented in this driver
> > uses mutex_lock() to protect its register updates. But this function is
> > called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop()
> > functions in iTCO_wdt.c driver, which in turn causes "sleeping into
> > atomic context" issue. This patch fixes this issue by replacing the
> > mutex_lock() with spin_lock() to protect the GCR read/write/update APIs.
> >
> > Fixes: 9d855d4 ("platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory
> > mapping failure")
> I think it need to be a one line.
Fixed it in v5 version. But it crosses 80 char limit. I am not sure 
whether its alright.
> Does it apply on top of v4.14-rc3 ?
Yes. Just checked it now. It applies cleanly on top of v4.14-rc3. But 
v5 patch set is re-based on top of your review branch.
So it has dependency on a patch ( "platform/x86: intel_pmc_ipc: Use 
devm_* calls in driver probe function") in your review branch.
> Btw, this patch should be first in the series.
Fixed it in v5 version.
>