Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

From: Liam Breck
Date: Thu Oct 05 2017 - 15:25:35 EST


Hi Joe,

On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote:
>>
>> On Fri, 6 Oct 2017, Masahiro Yamada wrote:
>>
>> > 2017-10-01 21:42 GMT+09:00 Julia Lawall <Julia.Lawall@xxxxxxx>:
>> > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
>> > > within a single structure. It is currently specific to the file
>> > > drivers/power/supply/bq27xxx_battery.c.
>> > >
>> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>> > >
>> > > ---
>> >
>> > Applied to linux-kbuild/misc.
>>
>> Thanks for picking it up.
>
> If it is specific to one file, why not just run it
> and post the resultant patch? Why have it in tree?

The driver which this script analyzes supports more than a dozen
different chips, which require different parameters. This script
checks for duplicate parameter arrays.