Re: [PATCH] KVM: add X86_LOCAL_APIC dependency

From: Radim KrÄmÃÅ
Date: Thu Oct 05 2017 - 14:01:21 EST


2017-10-04 12:28+0200, Arnd Bergmann:
> The rework of the posted interrupt handling broke building without
> support for the local APIC:
>
> ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined!
>
> That configuration is probably not particularly useful anyway, so
> we can avoid the randconfig failures by adding a Kconfig dependency.

Yeah, and we can follow up by removing few ifdefs.

> Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts")

The offending cpu_physical_id() was there even before, so it is probably
the change of condition in pi_post_block that violated dead code
detection.

> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Applied, thanks.