Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()

From: David Miller
Date: Thu Oct 05 2017 - 12:53:17 EST


From: Paul Bolle <pebolle@xxxxxxxxxx>
Date: Thu, 05 Oct 2017 09:58:56 +0200

> Hi Kees,
>
> On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote:
>> Also uses kzmalloc to replace open-coded field assignments to NULL and zero.
>
> If I'm allowed to whine (chances that I'm allowed to do that are not so great
> as Dave tends to apply gigaset patches before I even have a chance to look at
> them properly!): I'd prefer it if that was done separately in a preceding
> patch. Would that bother you?

Agreed, these timer transformations are already exhausting to review without
unrelated modifications sneaking in.