Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings
From: Chen-Yu Tsai
Date: Thu Oct 05 2017 - 11:51:32 EST
On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Some gpio-keys definitions in our DTs were having buttons defined with a
> unit-address and that would generate a DTC warning.
>
> Change the buttons node names to remove the warnings.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++-----------
> arch/arm/boot/dts/sun4i-a10-pcduino.dts | 6 +--
> 2 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> index 7c7f12132ea3..13224f5ac166 100644
> --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> @@ -67,7 +67,7 @@
> #size-cells = <0>;
> poll-interval = <20>;
>
> - button@0 {
> + left-joystick-left {
Does this fit the naming scheme? Should we have "-button" suffices?
Otherwise,
Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>