Re: [PATCH] mm, arch: remove empty_bad_page*

From: Ralf Baechle
Date: Thu Oct 05 2017 - 06:03:10 EST


On Wed, Oct 04, 2017 at 05:00:45PM +0200, Michal Hocko wrote:

> From: Michal Hocko <mhocko@xxxxxxxx>
>
> empty_bad_page and empty_bad_pte_table seems to be a relict from old
> days which is not used by any code for a long time. I have tried to find
> when exactly but this is not really all that straightforward due to many
> code movements - traces disappear around 2.4 times.
>
> Anyway no code really references neither empty_bad_page nor
> empty_bad_pte_table. We only allocate the storage which is not used by
> anybody so remove them.
>
> Cc: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Cc: Rich Felker <dalias@xxxxxxxx>
> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
> Cc: Richard Weinberger <richard@xxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: <uclinux-h8-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: <linux-mips@xxxxxxxxxxxxxx>
> Cc: <linux-sh@xxxxxxxxxxxxxxx>
> Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>

On MIPS the empty_bad_page_table definition was deleted in 2549fa57708d
("Small cleanups including deletion of two variables 4k each ...") in the
MIPS git tree on 2003-07-29, so

Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>

for getting rid of the rest a mere 14 years later.

Thanks,

Ralf