Re: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable

[Stephen Smalley]

On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch remove the unused variable sid
> This fix the following build warning:
> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
> used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>

Acked-by: Stephen Smalley <sds@xxxxxxxxxxxxx>

> ---
> Âsecurity/selinux/hooks.c | 3 +--
> Â1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index f5d304736852..8507a56f85e4 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct
> inode *inode, struct inode *dir,
> Â{
> Â	const struct task_security_struct *tsec =
> current_security();
> Â	struct superblock_security_struct *sbsec;
> -	u32 sid, newsid, clen;
> +	u32 newsid, clen;
> Â	int rc;
> Â	char *context;
> Â
> Â	sbsec = dir->i_sb->s_security;
> Â
> -	sid = tsec->sid;
> Â	newsid = tsec->create_sid;
> Â
> Â	rc = selinux_determine_inode_label(current_security(),