Re: [Part2 PATCH v4.1 07/29] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

From: P J P
Date: Wed Oct 04 2017 - 06:42:53 EST


+-- On Wed, 4 Oct 2017, Borislav Petkov wrote --+
| This is a function which maps commands to buffer lengths and it should be
| obvious at a *very* quick glance what it does. And that is best done if it
| is written in a tabular manner as we do such things in other places in the
| kernel too.

Quick glance would work if it is readable. Currently it is not if one is
viewing it in 80 cols screen/window. They do that. Writing return on the same
line does not add specific value IMO.

Up to you; I pointed it out as 80 columns rule makes sense to me.

--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F