Re: [PATCH 1/8] ARM: dts: aspeed: Move pinctrl subnodes to improve readability

From: Andrew Jeffery
Date: Tue Oct 03 2017 - 23:30:51 EST


On Thu, 2017-09-28 at 17:21 +0930, Joel Stanley wrote:
> > From: Andrew Jeffery <andrew@xxxxxxxx>
>
> Moving the subnodes out of the pinctrl node declaration to a reference
> allows easier access to the remaining parts of the devicetree.
>
> > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > Reviewed-by: Xo Wang <xow@xxxxxxxxxx>
> > Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> ---
> Âarch/arm/boot/dts/aspeed-g4.dtsi | 1483 ++++++++++++++++++------------------
> Âarch/arm/boot/dts/aspeed-g5.dtsi | 1549 +++++++++++++++++++-------------------
> Â2 files changed, 1518 insertions(+), 1514 deletions(-)

I hate the way the diff came out for the g5, it's almost impossible to
read. Also not sure how useful it is to ack my own patch, but given the
rebasing it has suffered:

Acked-by: Andrew Jeffery <andrew@xxxxxxxx>

Cheers,

Andrew

Attachment: signature.asc
Description: This is a digitally signed message part