Re: [PATCH 3/7] gpio: brcmstb: switch to handle_level_irq flow

From: Gregory Fong
Date: Tue Oct 03 2017 - 22:00:28 EST


On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger <opendmb@xxxxxxxxx> wrote:
> Reading and writing the gpio bank status register each time a pending
> interrupt bit is serviced could cause new pending bits to be cleared
> without servicing the associated interrupts.
>
> By using the handle_level_irq flow instead of the handle_simple_irq
> flow we get proper handling of interrupt masking as well as acking
> of interrupts. The irq_ack method is added to support this.
>
> Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>

Acked-by: Gregory Fong <gregory.0xf0@xxxxxxxxx>