Re: [PATCH] PCI / PM: Add dev_dbg() to print device suspend power states

From: Bjorn Helgaas
Date: Mon Oct 02 2017 - 19:29:58 EST


On Sat, Sep 30, 2017 at 01:31:15AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> It sometimes is useful to know what power states the kernel thinks
> it puts PCI devices into during system suspend, so add a dev_dbg()
> statement for that.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

I think you have other pending changes in this path, so can you take
this one as well?

> ---
> drivers/pci/pci-driver.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> Index: linux-pm/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-pm.orig/drivers/pci/pci-driver.c
> +++ linux-pm/drivers/pci/pci-driver.c
> @@ -798,6 +798,9 @@ static int pci_pm_suspend_noirq(struct d
> pci_prepare_to_sleep(pci_dev);
> }
>
> + dev_dbg(dev, "PCI PM: Suspend power state: %s\n",
> + pci_power_name(pci_dev->current_state));
> +
> pci_pm_set_unknown_state(pci_dev);
>
> /*
>