Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

[Andrew Lunn]

Hi Razvan

> +static void ethsw_get_drvinfo(struct net_device *netdev,
> +			      struct ethtool_drvinfo *drvinfo)
> +{
> +	struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> +	u16 version_major, version_minor;
> +	int err;
> +
> +	strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
> +	strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));

Software driver versions are mostly useless. I would suggest you
remove this.

       Andrew