Re: [PATCH] printk: simplify no_printk()

From: Petr Mladek
Date: Mon Oct 02 2017 - 10:56:35 EST


On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
> a value") surrounded the macro implementation with ({ ... }).
>
> Now, the inner do { ... } while (0); is redundant.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Looks fine to me. The return value is slightly more visible now ;-)

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

JFYI, I have pushed it into for-4.15 branch.

Best Regards,
Petr