Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

[Philipp Zabel]

Hi Marco,

On Fri, 2017-09-22 at 15:05 -0300, Marco Franchi wrote:
> Improve the binding example by removing the '@di0' notation, which
> fixes the following build warning:
> 
> Warning (unit_address_vs_reg): Node /display@di0 has a unit name, butÂ
> no reg property
> 
> Signed-off-by: Marco Franchi <marco.franchi@xxxxxxx>
> ---
> ÂDocumentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt
> index f798547..44814f0 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> @@ -129,7 +129,7 @@ Optional properties:
> Â
> Âexample:
> Â
> -display@di0 {
> +display-di0 {
> Â	compatible = "fsl,imx-parallel-display";
> Â	edid = [edid-data];
> Â	interface-pix-fmt = "rgb24";

Thank you for the patch.ÂWe certainly should get rid of the @di0
notation. Since these nodes mostly describe the DISP0 and DISP1 pin
groups controlled by the IOMUXC, I'd prefer to rename this to

-display@di0 {
+disp0 {

instead, if that is fine with you.

I'd also like to move the disp0/disp1 nodes into the SoC dtsi files to
avoid having to duplicate port@0 all over the place.

regards
Philipp