Re: [PATCH] firmware: tegra: add BPMP debugfs support

[Timo Alho]

On 29.09.2017 17:58, Jonathan Hunter wrote:
> > > > +static int bpmp_populate_dir(struct tegra_bpmp *bpmp, struct seqbuf
> > > > *seqbuf,
> > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ struct dentry *parent, uint32_t depth)
> > >
> > > Do we need to use uint32_t here?
> > >
> > > > +{
> > > > +ÂÂÂ int err;
> > > > +ÂÂÂ uint32_t d, t;
> > >
> > > And here?
> >
> > It's part of the BPMP ABI that the data passed is 32 bit unsigned
> > integer. I wanted to emphasise that with the choice of integer type. Or
> > did you mean why I did not use u32?
>
> Yes why not just u32?

No other reason than just a personal bias to use standard C99 integer 
types. The downstream driver was using a mix of both so wanted to 
standardize to just one.