Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames

From: Joe Perches
Date: Sun Oct 01 2017 - 13:40:45 EST


On Sun, 2017-10-01 at 14:37 +0200, Milian Wolff wrote:
> On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
[]
> > nit, think we prefer the /* */ comment style
>
> I'll fix this, but note that there are more places outside this patch series
> where this style has crept in. Some of them also from past patches of mine -
> sorry for that.

I think c99 comments are fine.
So did Linus Torvalds.

http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html

> I looks to me as if the checkpatch.pl should catch this, but it doesn't for me
> which is odd. Does anyone know what I need to do to enable the C99_COMMENTS
> check?

Modify checkpatch

my $allow_c99_comments = 1;

change the 1 to 0

Add a runtime option if you want.