RE: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ?

From: Zheng, Lv
Date: Wed Sep 27 2017 - 23:01:24 EST


Hi, David

Not a fancy way, but just a bit clearing.
OK, style is changed here:
https://github.com/acpica/acpica/pull/321
And bug is recorded here:
https://bugs.acpica.org/show_bug.cgi?id=1422

Thanks for the report.

Best regards
Lv

> From: David Binderman [mailto:dcb314@xxxxxxxxxxx]
> Subject: linux-4.14-rc2/drivers/acpi/acpica/utmath.c: 2 * suspicious expression ?
>
> Hello there,
>
> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:137]:
> (style) Same expression on both sides of '^='.
> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174] -> [linux-4.14-rc2/drivers/acpi/acpica/utmath.c:174]:
> (style) Same expression on both sides of '^='.
>
> operand_ovl.part.lo ^= operand_ovl.part.lo;
>
> Is this just a fancy way to zero the field or should something more clever
> be happening ?
>
> Regards
>
> David Binderman
>