Re: [PATCH] IB/ocrdma: pr_err() strings should end with newlines

[Arvind Yadav]

Hi Yuval,


On Tuesday 26 September 2017 12:49 PM, Yuval Shaia wrote:
> On Tue, Sep 26, 2017 at 12:21:44PM +0530, Arvind Yadav wrote:
> > pr_err() messages should end with a new-line to avoid other messages
> > being concatenated.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> > ---
> >   drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> > index 66056f9..e528d7a 100644
> > --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> > @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> >   		if (reset) {
> >   			status = ocrdma_mbx_rdma_stats(dev, true);
> >   			if (status) {
> > -				pr_err("Failed to reset stats = %d", status);
> > +				pr_err("Failed to reset stats = %d\n", status);
> >   				goto err;
> >   			}
> >   		}
> While there, can you also fix line 1096 in ocrdma_hw.c?
>
> (is it too naive to expect checkptahc to catch such errors?)
As per your suggestion, I have done  the changes.
> > --
> > 1.9.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
~arvind