Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

[Mark yao]

On 2017å09æ26æ 13:12, Daniel Vetter wrote:
> On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote:
> > On 2017å09æ21æ 06:29, Thomas Meyer wrote:
> > > Use vma_pages function on vma object instead of explicit computation.
> > > Found by coccinelle spatch "api/vma_pages.cocci"
> > >
> > > Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> > > ---
> > Looks good for me:
> > Acked-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
> Once more a maintainer who acks a patch and doesn't push it. This is
> really confusing, who exactly do you expect to handle this patch for you?
>
> Please push to drm-misc-next (also for future patches), thanks.
> -Daniel

Hi Daniel
I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series.

Ok, Pushed it to drm-misc-next.

> > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_
> > >    {
> > >    	struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj);
> > >    	unsigned int i, count = obj->size >> PAGE_SHIFT;
> > > -	unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > > +	unsigned long user_count = vma_pages(vma);
> > >    	unsigned long uaddr = vma->vm_start;
> > >    	unsigned long offset = vma->vm_pgoff;
> > >    	unsigned long end = user_count + offset;
> > >
> > > _______________________________________________
> > > Linux-rockchip mailing list
> > > Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
> > --
> > ïark Yao
> >
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel


--
ïark Ya