Re: [PATCH v2 1/4] Add a new element for the struct perf_tool, and add the --per-event-dump option for perf script

From: David Ahern
Date: Mon Sep 25 2017 - 22:44:34 EST


On 9/25/17 8:41 PM, çèé wrote:
> The changelogs are in the cover-letter.
> changes in v2:
> Â Â Â Â - remove the set of script.tool.per_event_dump variable.
> Â Â Â Â - add the __maybe_unused attribute for the fp argument in the
> second patch.
> Â Â Â Â - remove the fp_selection_helper function for setting the fp
> argument.
> Â Â Â Â - split the original second patch(Makes all those related
> functions receive the FILE pointer) to two patches.
> Â Â Â Â - modify the file name of per-event-dump to <ORIGINAL PERF DATA
> FILE NAME>-script-dump-<EVENT NAME>.txt

Each patch should have a single focus and a changelog describing what is
changed and why. Impacts to the user experience should have example output.