Re: [PATCH] drm: of: always initialize panel in drm_of_find_panel_or_bridge()

From: Linus Walleij
Date: Mon Sep 25 2017 - 11:34:24 EST


On Mon, Sep 25, 2017 at 12:30 PM, Dan Carpenter
<dan.carpenter@xxxxxxxxxx> wrote:

> The callers expect "panel" to be initialized, but that isn't true if we
> return -ENODEV. It causes bugs like:
>
> drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init()
> error: uninitialized symbol 'panel'.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I am travelling right now but will apply the patch on monday in
one week from now.

Yours,
Linus Walleij