Re: [PATCH 0/4] iio: light: vl6180: Several fixes and enhancements

From: Jonathan Cameron
Date: Sun Sep 24 2017 - 11:40:57 EST


On Tue, 19 Sep 2017 05:11:40 +0200
Stefan BrÃns <stefan.bruens@xxxxxxxxxxxxxx> wrote:

> Currently, the vl6180 driver reports bogus in_illuminance_scale values
> when the integration time or hardware gain are changed from its default
> value, i.e. it always reports a fixed value.
>
> To avoid readback of the register values in case integration time, gain
> or scale is queried, save the register values. Use the saved values
> to report the correct scale value.

Hmm. I think unfortunately that this set is too large and invasive
to send as a fix. Hence once the little corners are tidied up I'll
take it via the slow path ready for the next merge window.

Thanks,

Jonathan

>
> Stefan BrÃns (4):
> iio: light: vl6180: Move range check to integration time setter,
> cleanup
> iio: light: vl6180: Avoid readback of integration time register
> iio: light: vl6180: Cleanup als_gain lookup, avoid register readback
> iio: light: vl6180: Correct ALS scale for non-default gain/integration
> time
>
> drivers/iio/light/vl6180.c | 125 +++++++++++++++++++++++++--------------------
> 1 file changed, 69 insertions(+), 56 deletions(-)
>