RE: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection

From: Brown, Aaron F
Date: Thu Sep 14 2017 - 20:19:07 EST


> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On Behalf
> Of Benjamin Poirier
> Sent: Friday, July 21, 2017 11:36 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Lennart Sorensen <lsorense@xxxxxxxxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection
>
> In case of error from e1e_rphy(), the loop will exit early and "success"
> will be set to true erroneously.
>
> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxxx>
> ---
> drivers/net/ethernet/intel/e1000e/phy.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>

Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>