Re: [PATCH v2 2/3] efi: call get_event_log before ExitBootServices

From: kbuild test robot
Date: Wed Sep 13 2017 - 10:49:59 EST


Hi Thiebaud,

[auto build test ERROR on efi/next]
[also build test ERROR on next-20170913]
[cannot apply to char-misc/char-misc-testing linus/master v4.13]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Thiebaud-Weksteen/Call-GetEventLog-before-ExitBootServices/20170913-221312
base: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64

Note: the linux-review/Thiebaud-Weksteen/Call-GetEventLog-before-ExitBootServices/20170913-221312 HEAD 58dc8ee5de3bb5fb1ef216b80a76102d2de2b141 builds fine.
It only hurts bisectibility.

All errors (new ones prefixed by >>):

drivers/firmware/efi/tpm.c: In function 'efi_tpm_eventlog_init':
>> drivers/firmware/efi/tpm.c:24:9: error: 'struct efi' has no member named 'tpm_log'
if (efi.tpm_log == EFI_INVALID_TABLE_ADDR)
^
In file included from arch/ia64/include/asm/io.h:23:0,
from arch/ia64/include/asm/smp.h:20,
from include/linux/smp.h:59,
from include/linux/percpu.h:6,
from include/linux/percpu-rwsem.h:6,
from include/linux/fs.h:32,
from include/linux/proc_fs.h:8,
from include/linux/efi.h:18,
from drivers/firmware/efi/tpm.c:10:
drivers/firmware/efi/tpm.c:27:26: error: 'struct efi' has no member named 'tpm_log'
tbl = early_memremap(efi.tpm_log, sizeof(*tbl));
^
arch/ia64/include/asm/early_ioremap.h:5:62: note: in definition of macro 'early_memremap'
#define early_memremap(phys_addr, size) early_ioremap(phys_addr, size)
^~~~~~~~~
In file included from include/linux/kernel.h:13:0,
from include/linux/list.h:8,
from include/linux/preempt.h:10,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/linux/efi.h:16,
from drivers/firmware/efi/tpm.c:10:
drivers/firmware/efi/tpm.c:30:7: error: 'struct efi' has no member named 'tpm_log'
efi.tpm_log);
^
include/linux/printk.h:301:33: note: in definition of macro 'pr_err'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~
drivers/firmware/efi/tpm.c:35:22: error: 'struct efi' has no member named 'tpm_log'
memblock_reserve(efi.tpm_log, tbl_size);
^

vim +24 drivers/firmware/efi/tpm.c

15
16 /*
17 * Reserve the memory associated with the TPM Event Log configuration table.
18 */
19 int __init efi_tpm_eventlog_init(void)
20 {
21 struct linux_efi_tpm_eventlog *tbl;
22 unsigned int tbl_size;
23
> 24 if (efi.tpm_log == EFI_INVALID_TABLE_ADDR)
25 return 0;
26
27 tbl = early_memremap(efi.tpm_log, sizeof(*tbl));
28 if (!tbl) {
29 pr_err("Failed to map TPM Event Log table @ 0x%lx\n",
30 efi.tpm_log);
31 return -ENOMEM;
32 }
33
34 tbl_size = sizeof(*tbl) + tbl->size;
35 memblock_reserve(efi.tpm_log, tbl_size);
36 early_memunmap(tbl, sizeof(*tbl));
37 return 0;
38 }
39

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip