Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

From: Jiri Kosina
Date: Wed Sep 13 2017 - 10:02:14 EST


On Fri, 8 Sep 2017, Dmitry Torokhov wrote:

> From: Adrian Salido <salidoa@xxxxxxxxxx>
>
> The buffer allocation is not currently accounting for an extra byte for
> the report id. This can cause an out of bounds access in function
> i2c_hid_set_or_send_report() with reportID > 15.
>
> Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Missing signoff from the patch author?

Also, I think this should have Cc: stable, right?

Thanks,

--
Jiri Kosina
SUSE Labs