Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

From: Bart Van Assche
Date: Tue Sep 12 2017 - 11:16:10 EST


On Tue, 2017-09-12 at 12:32 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate const arrays on the stack, instead make them
> static. Makes the object code smaller by over 740 bytes.
>
> Before:
> text data bss dec hex filename
> 3840 208 0 4048 fd0 drivers/scsi/ufs/tc-dwc-g210.o
>
> After:
> text data bss dec hex filename
> 2679 624 0 3303 ce7 drivers/scsi/ufs/tc-dwc-g210.o
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Please CC the most active contributors of a driver when submitting a driver
patch. Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>