Re: [PATCH] pinctrl: uniphier: make arrays static, reduces object code size

From: Linus Walleij
Date: Tue Sep 12 2017 - 10:19:37 EST


On Tue, Sep 12, 2017 at 1:21 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate const arrays on the stack, instead make them
> static. Makes the object code smaller nearly 1000 bytes. Also
> line break wide lines to avoid checkpatch warnings.
>
> Before:
> text data bss dec hex filename
> 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o
>
> After:
> text data bss dec hex filename
> 11642 2476 0 14118 3726 pinctrl-uniphier-core.o
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied with Masahiro's ACK.

Yours,
Linus Walleij