Re: [PATCH v5 10/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs

From: Corentin Labbe
Date: Tue Sep 12 2017 - 03:54:30 EST


On Mon, Sep 11, 2017 at 10:19:20PM +0200, Andrew Lunn wrote:
> > Even with CLK_BUS_EPHY/RST_BUS_EPHY enabled, the MAC reset timeout.
> > So no the CLK/RST are really for the PHY.
>
> Thanks for trying that.
>
> You said it was probably during scanning of the bus it times out. What
> address is causing the timeout? 0 or 1? If the internal bus can only
> have one PHY on it, maybe we need to set bus->phy_mask to 0x1?
>

I have added a trace in begin and end of stmmac_mdio_read()

[ 18.145451] libphy: stmmac: probed
[ 18.148398] libphy: mdio_mux: probed
[ 18.148650] dwmac-sun8i 1c30000.ethernet: Switch mux to internal PHY
[ 18.248751] dwmac-sun8i 1c30000.ethernet: EMAC reset timeout
[ 18.249297] libphy: mdio_mux: probed
[ 18.249362] dwmac-sun8i 1c30000.ethernet: Switch mux to external PHY
[ 18.249391] stmmac_mdio_read 0 2
[ 18.249598] stmmac_mdio_read 0 2 1c
[ 18.249623] stmmac_mdio_read 0 3
[ 18.249811] stmmac_mdio_read 0 3 c915
[ 20.737271] EXT4-fs (mmcblk0p1): re-mounted. Opts: (null)
[ 31.294868] stmmac_mdio_read 0 0
[ 31.295311] stmmac_mdio_read 0 0 1140

It seems that the timeout is unrelated to MDIO bus.

Regards