Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

From: Benson Leung
Date: Mon Sep 11 2017 - 15:48:16 EST


Hi Brian,

On Fri, Sep 08, 2017 at 01:50:11PM -0700, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@xxxxxxxxxxxx>
>
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
>
> Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton")
> Signed-off-by: Shawn Nematbakhsh <shawnn@xxxxxxxxxxxx>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Looks good. Applied for v4.14.

Thanks!
Benson

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@xxxxxxxxxx
Chromium OS Project
bleung@xxxxxxxxxxxx

Attachment: signature.asc
Description: Digital signature