Re: [PATCH] media: default for RC_CORE should be n

From: Mauro Carvalho Chehab
Date: Fri Sep 08 2017 - 17:52:13 EST


Em Fri, 8 Sep 2017 12:06:48 -0700
Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> escreveu:

> On Fri, 8 Sep 2017 19:52:47 +0100
> Sean Young <sean@xxxxxxxx> wrote:
>
> > On Fri, Sep 08, 2017 at 09:39:29AM -0700, Stephen Hemminger wrote:
> > > The Linus policy on Kconfig is that the default should be no
> > > for all new devices. I.e the user rebuild a new kernel from an
> > > old config should not by default get a larger kernel.
> >
> > That might make sense for new config, but RC_CORE has been present for
> > 7 years; I don't see how changing defaults for existing config makes
> > sense.
> >
>
> I took existing config for 4.13 and did 'make oldconfig' and just
> hitting return caused it to turned on.
>
> The problem is that in my config media is disabled, and now your new
> reconfiguration makes RC_CORE not dependent on media.
>
> It is a common problem, developers never test with their subsystem disabled.

Hi Sean,

Yes, it makes sense to default 'n' for RC_CORE now that this is an
independent menu option and it builds the RC core when enabled.

Regards,
Mauro