Re: [PATCH V2] thermal/drivers/step_wise: Fix temperature regulation misbehavior

[Daniel Lezcano]

On 08/09/2017 14:25, Keerthy wrote:
> 
[ ... ]

> This definitely is an issue i have seen on dra7 and if step_wise by
> design can accommodate this change, It will fix the issue!

Ah, ok. I understood you thought we should not do the change and use the
DT crit trip instead.

> Then you should be updating the documentation as well.
> 
> /*
>  * If the temperature is higher than a trip point,
>  *    a. if the trend is THERMAL_TREND_RAISING, use higher cooling
>  *       state for this trip point
>  *    b. if the trend is THERMAL_TREND_DROPPING, use lower cooling
>  *       state for this trip point
> 
> Now with your patch applied the point b. will change to:
> 
> b. if the trend is THERMAL_TREND_DROPPING, Maintain the same cooling
> level till the temperature drops below trip point.

Ok, I will change accordingly.

Thanks.

  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog