Re: [PATCH] selftests: timers: remove rtctest_setdate from run_destructive_tests

From: Benjamin Gaignard
Date: Wed Aug 23 2017 - 08:27:34 EST


2017-08-22 22:23 GMT+02:00 Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>:
> Remove rtctest_setdate from run_destructive_tests target. Leave it in
> TEST_GEN_PROGS_EXTENDED to be included in the install targets.
>
> Suggested-by: John Stultz <john.stultz@xxxxxxxxxx>
> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>

> ---
> tools/testing/selftests/timers/Makefile | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index 4ed9e45c7f38..de85358ae937 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -6,15 +6,17 @@ LDFLAGS += -lrt -lpthread -lm
> TEST_GEN_PROGS = posix_timers nanosleep nsleep-lat set-timer-lat mqueue-lat \
> inconsistency-check raw_skew threadtest rtctest
>
> -TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew \
> +DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
> skew_consistency clocksource-switch freq-step leap-a-day \
> - leapcrash set-tai set-2038 set-tz rtctest_setdate
> + leapcrash set-tai set-2038 set-tz
> +
> +TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS) rtctest_setdate
>
>
> include ../lib.mk
>
> define RUN_DESTRUCTIVE_TESTS
> - @for TEST in $(TEST_GEN_PROGS_EXTENDED); do \
> + @for TEST in $(DESTRUCTIVE_TESTS); do \
> BASENAME_TEST=`basename $$TEST`; \
> if [ ! -x $$BASENAME_TEST ]; then \
> echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
> --
> 2.11.0
>



--
Benjamin Gaignard

Graphic Study Group

Linaro.org â Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog