Re: [PATCH] staging: fsl-mc: move bus driver out of staging

From: Laurentiu Tudor
Date: Wed Aug 23 2017 - 05:09:12 EST




On 08/23/2017 04:39 AM, Greg KH wrote:
> On Sat, Aug 19, 2017 at 08:18:12PM +0300, laurentiu.tudor@xxxxxxx wrote:
>> From: Stuart Yoder <stuart.yoder@xxxxxxx>
>>
>> Move the source files out of staging into their final locations:
>> -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
>> -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
>> -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
>> -README.txt, providing and overview of DPAA goes to
>> Documentation/dpaa2/overview.txt
>>
>> Update or delete other remaining staging files-- Makefile, Kconfig, TODO.
>> Update dpaa2_eth and dpio staging drivers.
>>
>> Signed-off-by: Stuart Yoder <stuyoder@xxxxxxxxx>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
>> [Laurentiu: rebased, add dpaa2_eth and dpio #include updates]
>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>
> Really? You all have fixed all of the previous issues found?

Well, it went through quite a few rounds of fixes and cleanups (driver
model related + other fixes, cleanup [1], more cleanup, fixes [2],
header file cleanup [3], compile multi-arch [4]) addressing the found
issues.

> Is it time for another real review? If so, please ask for it.

Yes, please review. Thanks in advance!

[1] https://lkml.org/lkml/2017/2/1/235
[2] https://www.spinics.net/lists/arm-kernel/msg586688.html
[3] https://www.spinics.net/lists/arm-kernel/msg590928.html
[4] https://lkml.org/lkml/2017/7/19/639
---
Thanks & Best Regards, Laurentiu